Prevent Firefox's global paste behavior if paste target is not also focused #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Was able to add a test thanks to guidance here: microsoft/playwright#8114 |
|
Demo of test showing the fix! Screenshare.-.2024-06-04.1_48_03.PM-compressed.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2285 by preventing Firefox's unique behavior where users can globally paste into their last-focused input or contenteditable field, even when that field is not the currently-focused element.
Demo
Performed in Firefox on Ubuntu. The first portion is with the fix, then I revert and stash the commit to show the broken behavior. Note how with the fix, users can still paste with any method including middle click, but now must have the code pane (or another input such as the KCL expression input in the command bar) focused before they can paste into it.
Screencast.from.2024-06-03.14-55-05.webm