-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Ignore KCL changes when loading settings and fixed useEffect to use .current #5126
base: main
Are you sure you want to change the base?
Conversation
…cher to not watch .kcl files when loading settings
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably our WS BS that we're dealing with right now.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5126 +/- ##
=======================================
Coverage 85.94% 85.94%
=======================================
Files 90 90
Lines 32718 32718
=======================================
Hits 28121 28121
Misses 4597 4597
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Issue
.current
.kcl
file in a project while in the model scene all of the settings reload from disk into memoryImplementation
.current
from the getterAny time we edited a
.kcl
file from code mods or if the user is typing it would reload all of the project settings from disk into memory. That logic does not need to run. By writing the wrong react API logic I uncovered that the settings were constantly being reloaded from disk because my getter kept getting set again even though the.current
value inside was not changing. I am glad I wrote the line of code wrong to find this.