Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove dead code to update the artifact graph after mock execution #5158

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jtran
Copy link
Collaborator

@jtran jtran commented Jan 27, 2025

Nothing ever uses this parameter. It always uses the default. We should delete it.

Related to #5166.

Copy link

qa-wolf bot commented Jan 27, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jan 31, 2025 11:08pm

@jtran jtran force-pushed the jtran/remove-dead-artifact-update branch from 0a67856 to 574f4b4 Compare January 27, 2025 18:16
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.95%. Comparing base (e0ef10e) to head (7b8aa17).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5158   +/-   ##
=======================================
  Coverage   85.95%   85.95%           
=======================================
  Files          90       90           
  Lines       32893    32893           
=======================================
  Hits        28272    28272           
  Misses       4621     4621           
Flag Coverage Δ
wasm-lib 85.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Irev-Dev Irev-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool yeah I think it was used at some point.

Probably a long time ago.

@jtran jtran enabled auto-merge (squash) January 29, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants