Fix flaky e2e test with nondeterministic project list order #5215
+31
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jtran
approved these changes
Feb 2, 2025
I think creating them in Promise.all was introducing nondeterminism and making tests flaky.
adamchalmers
force-pushed
the
achalmers/test-main-e2e
branch
from
287d8e2 to
ebf8c0a
Compare
adamchalmers
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5215 +/- ##
=======================================
Coverage 85.95% 85.95%
=======================================
Files 90 90
Lines 32906 32912 +6
=======================================
+ Hits 28285 28291 +6
Misses 4621 4621
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jtran
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test "Opening a project should successfully load the stream" creates two projects. Then it queries the projects, checking both projects were created. However, the projects are returned in a nondeterministic order, which means the test flakes.
I think the nondeterminism is because they're created with a
Promise.all, so I've instead changed it to create the projects in a specific order.I've also queried the projects in an order-insensitive way.