-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix resizing view breaking app on high DPI displays #5275
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
2025-02-04_17-30-59.mp4 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5275 +/- ##
=======================================
Coverage 86.05% 86.05%
=======================================
Files 92 92
Lines 33204 33204
=======================================
Hits 28575 28575
Misses 4629 4629
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm this makes it possible to work with selections on a fullscreen app with native resolution of 3024x1964 here. Which currently doesn't work on main.
@adamchalmers confirmed on his monster monitor! |
I was only able to test this through DPI emulation, but I was able to reproduce. Please try on your Mac screens.
The issue was kind of a mix of sub issues: