Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deep links on Linux .desktop files #5337

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

pierremtb
Copy link
Collaborator

@pierremtb pierremtb commented Feb 11, 2025

Fixes #5325

The --no-sandbox extra arg passed by the default .desktop file is causing the argv[1] lookup to be the wrong one.
image

Copy link

qa-wolf bot commented Feb 11, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 11, 2025 5:08pm

Copy link
Collaborator

@franknoirot franknoirot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good investigative work!

@pierremtb pierremtb enabled auto-merge (squash) February 11, 2025 16:56
@pierremtb pierremtb merged commit d0c8311 into main Feb 11, 2025
33 checks passed
@pierremtb pierremtb deleted the pierremtb/issue5325-Fix-deep-links-on-Linux branch February 11, 2025 17:25
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.80%. Comparing base (1628560) to head (b10ee69).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5337   +/-   ##
=======================================
  Coverage   85.80%   85.80%           
=======================================
  Files          94       94           
  Lines       33554    33554           
=======================================
  Hits        28792    28792           
  Misses       4762     4762           
Flag Coverage Δ
wasm-lib 85.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix deep links on Linux
2 participants