Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace aria-hidden toggling with the aria-modal attribute #155

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

KittyGiraudel
Copy link
Owner

@KittyGiraudel KittyGiraudel commented Feb 27, 2021

Demo: https://codesandbox.io/s/wonderful-fermat-bmovn?file=/src/a11y-dialog.js
Docs: #164
Requirements: #158
Changes:

  • The container property is now this.$el
  • The dialog property no longer exists
  • The role attribute is added by the script if not present
  • The aria-modal attribute is added by the script
  • The open attribute is no longer manipulated
  • The concept of targets no longer exists

@KittyGiraudel KittyGiraudel force-pushed the aria-modal branch 2 times, most recently from d9c2e3a to 5900e83 Compare February 27, 2021 14:14
@KittyGiraudel
Copy link
Owner Author

Let’s push that for v7, and remove the concept of “targets“ entirely.

@KittyGiraudel KittyGiraudel force-pushed the aria-modal branch 3 times, most recently from 2f28c9e to b753a0a Compare February 27, 2021 19:42
@KittyGiraudel KittyGiraudel added this to the 7.0.0 milestone Feb 27, 2021
@KittyGiraudel KittyGiraudel changed the title Recommend using the aria-modal attribute Replace aria-hidden toggling with the aria-modal attribute on the dialog Feb 27, 2021
@KittyGiraudel KittyGiraudel force-pushed the aria-modal branch 4 times, most recently from 04054d6 to 777937d Compare February 28, 2021 15:14
@KittyGiraudel KittyGiraudel changed the title Replace aria-hidden toggling with the aria-modal attribute on the dialog Replace aria-hidden toggling with the aria-modal attribute Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant