-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
group resources by path #5
Conversation
This fixes the aglio warnings. Aglio will now group the resources in the navigation bar like this: I preferred it the way before, but I don't like the warnings. Aglio will only show route parameters if they are defined within our macro. In the next screenshot, both actions are grouped under the same resource path |
It turns out that it is possible to define parameters directly under the resource path headers. For example:
You can put all parameters under the resource path headers as above, or you could place the route parameters under the resource path headers and the query parameters under the action headers, like this:
The generated action headers and example routes will then always contain the path parameters (as they should), but only include those query parameters that are included in the tests. This would be very nice for the generated documentation, but we would have to determine how to get the parameter information of all the actions on a path. We'd have to define the resource path information separately from the |
Yes, this will be a challenge. But I think this will not be that difficult. We have to expand the logic for matching the documented routes with the "real" routes a little bit, like cutting the routes for parameter or allowing them. |
I don't know what you mean with Let's leave this pull request as it is for now and release 0.3.1 soon. |
Addresses issue #2.