fix desktop ordering error #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some ordering issues with sparsed tracks in a CSV.
Specifically if you had sparsely populated tracks it would throw an ordering error.
I.E if you had tracks on frame 1, 3, 5 the logic from before would throw an error about being out of order but that isn't necessarily true. That logic just checked to make sure that the next frame in each instance was equal to the current frame + 1, we really just want the next frame to be greater than the lower frame and throw and error if it isn't.
To add to this I also did some pre-sorting of the frames. Annotators kept giving my CSV files that don't have the frame ordering sorted.