Add filter and transcode pipelines #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnesbitt
commented
Nov 22, 2024
Comment on lines
129
to
134
| // TODO: Investigate if any other types can use this. | ||
| if (runPipelineArgs.pipeline.type === 'filter') { | ||
| command.push(`-s kwa_writer:output_directory="${npath.join(jobWorkDir, 'output')}"`); | ||
| command.push('-s image_writer:file_name_template="frame%06d.jpg"'); | ||
| command.push('-s image_writer:type="vxl"'); | ||
| } |
There was a problem hiding this comment.
This is to accommodate some pipeline args that I noticed were missing. This afaik is not a complete list, but does allow for some pipelines like filter_to_kwa to be run.
jjnesbitt
force-pushed
the
image-formatting-pipelines
branch
from
c3d1821 to
4abae43
Compare
BryonLewis
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes filter and transcode pipelines to the client. Results from these jobs are placed in the job work directory.