Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serializer): register vtkCompositePolyDataMapper #68

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

ChristosT
Copy link
Contributor

@ChristosT ChristosT commented Apr 19, 2024

The missing registration causes examples of pyvista that utilize multiblock to fail.
These are currently broken see:

The suggested change fixes the issue. See the last two examples in https://pyvist-multiblock-examples-issues.netlify.app/some_plots.

The problem was found by exporting export TRAME_SERIALIZE_DEBUG=1 and compiling via sphinx the above example.

@jourdain
Copy link
Collaborator

That won't work. vtk.js does not have such mapper.

@jourdain jourdain merged commit d8c55a8 into Kitware:master Apr 22, 2024
3 checks passed
@ChristosT ChristosT deleted the fix-mapper-registration branch April 22, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants