Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix test errors steming from the new multi-threading mechanism. #29

Merged

Conversation

jhlegarreta
Copy link
Collaborator

Fix errors steming from the use of the new itk::PoolMultiThreader
class for multi-threading.

The errors stemmed when this gerrit topic got merged:
http://review.source.kitware.com/#/c/23175/

And were later related to the following gerrit-topic:
http://review.source.kitware.com/#/c/23434/

The solution adopted in this patch set was based on the proposal in:
http://review.source.kitware.com/#/c/23439/

Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 4 specializations of RegionOfInterestImageFilter in this file, they all need explicitly set m_DynamicMultiThreading.

@jhlegarreta jhlegarreta force-pushed the FixPoolMultiThreaderErrors branch from 738a5b6 to fdf4648 Compare May 23, 2018 18:32
@jhlegarreta
Copy link
Collaborator Author

Again, thanks for being so careful with the review @dzenanz . fdf4648 addresses the issue.

Fix errors steming from the use of the new `itk::PoolMultiThreader`
class for multi-threading.

The errors stemmed when this gerrit topic got merged:
http://review.source.kitware.com/#/c/23175/

And were later related to the following gerrit-topic:
http://review.source.kitware.com/#/c/23434/

The solution adopted in this patch set was based on the proposal in:
http://review.source.kitware.com/#/c/23439/
@dzenanz
Copy link
Member

dzenanz commented May 23, 2018

I worked recently on finding some non-trivial bugs in this module, so I knew that without even looking 😄

Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the remotes Jon!

@thewtex thewtex merged commit 6a2326b into KitwareMedical:master May 26, 2018
@jhlegarreta jhlegarreta deleted the FixPoolMultiThreaderErrors branch May 28, 2018 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants