Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Qidi Plus 4 #6800

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Qidi Plus 4 #6800

wants to merge 1 commit into from

Conversation

liberodark
Copy link

@liberodark liberodark commented Jan 30, 2025

The Goal of this PR is to try to upstream change for Qidi Plus 4.
For add Support of this printer.

@liberodark liberodark force-pushed the qidi branch 13 times, most recently from 26adac0 to 3d81f86 Compare January 30, 2025 18:05
@liberodark liberodark marked this pull request as ready for review January 30, 2025 18:19
@Neko-vecter
Copy link
Contributor

Neko-vecter commented Jan 30, 2025

The Goal of this PR is to try to upstream change for Qidi Plus 4. For add Support of this printer.

If a PR relate to a specific function of specific printer. That mean the printer require a specific repo to implement. The mainstream only focus the function that every device require. You should using your own repo to make this implement.

For example, every printer will add command SAVE_CONFIG_QD even if the printer is not this one.

-Neko.vecter

@Neko-vecter
Copy link
Contributor

Neko-vecter commented Jan 30, 2025

If you want to add this function to Klipper it can be able using the method like Happy-Hare. Add you own file by using ln command.

-Neko.vecter

@Sineos
Copy link
Collaborator

Sineos commented Jan 31, 2025

  1. Please be aware that you need to sign off your PR for the certificate of origin as per point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review, including the rest of the points.
  2. As indicated by @Neko-vecter, it is very unlikely that the PR will be accepted in any way:
    • It contains "extras" that are not compatible with the main Klipper philosophy, e.g., gcode_shell_command.py.
    • Only functionality that is beneficial to a larger user and hardware base is accepted, not to a single printer and its specific hardware.
    • Multiple features should always be in separate PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants