Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dagger from 2.28.3 to 2.34.1 #122

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 14, 2021

Bumps dagger from 2.28.3 to 2.34.1.

Release notes

Sourced from dagger's releases.

Dagger 2.34.1

Hilt Bug fixes

  • Fix #2070: Fix leak in FragmentContextWrapper by also releasing the inflators, if they exists. (41c4e04da)

Dagger 2.34

What’s New in Dagger

Bug fixes

  • Fixed an issue where in rare cases subcomponent builder bindings might accidentally attach to the wrong parent (c2d097fa4)
  • Build performance improvements (47123ec9b, 1caa7f090, e2f2b2d96)

What’s New in Hilt

Hilt has a new flag, -Adagger.hilt.shareTestComponents, that enables tests with no test-specific bindings (e.g. @BindValue fields or @InstallIn modules within the test class) to share the same generated component. This flag should help improve build times by avoiding generating duplicate components for tests with the same bindings (faebc3c66).

Note: This flag is currently disabled by default, but will be enabled by default in a future release of Hilt. For more information on how to enable this flag as well as some caveats, see the docs

New breaking changes

The alpha androidx extension @ViewModelInject is no longer supported. @ViewModelInject has been deprecated since androidx.hilt 1.0.0-alpha03 and was removed in androidx.hilt 1.0.0-beta01. Hilt now falls back to the base activity/fragment default ViewModelProviderFactory (3778ee2b8)

Migration steps:

Users of @ViewModelInject can migrate to @​HiltViewModel which was added in Dagger 2.31.

  1. Add @HiltViewModel annotation to the class
  2. Replace the @ViewModelInject annotation on the constructor with @Inject.
  3. Remove @Assisted from the SavedStateHandle constructor parameter, if it exists
  4. Remove the old androidx.hilt:hilt-lifecycle-viewmodel dependency from your build.gradle file

Bug fixes

  • Update the androidx fragment, lifecycle and activity dependencies which contain patch fixes. (efcdbe12, 57255db62)
  • Fix #2511: updates the kotlinx-metadata dependency. (b42731b50)
  • Fix issue with proguard removing entry points by adding proguard keep rules. (96171b0ef)
  • Fix #2456: Rename init() method in generated Activity to avoid conflict with user method of same name. (1c66033f5)
  • Reduce the possibility of KAPT logging warnings due to no processor supporting disableAndroidSuperclassValidation when no Android entry points are in the source module. (c70cf2d38)
  • Fix #2070: Clears the Fragment reference in FragmentContextWrapper after Fragment#onDestroy() to prevent leaks if a non-Hilt View outlives the Hilt Fragment that created it. (7f4c3a236)

Dagger 2.33

What’s New in Dagger

Bug fixes

What’s New in Hilt

... (truncated)

Commits
  • 12c6a55 2.34.1 release
  • 41c4e04 Fix leak in FragmentContextWrapper by releasing the baseInflator if it exists.
  • c57ab0a Add a private constructor to the generated @​HiltViewModel module.
  • e8e12a0 Generate a separate TestComponentDataSupplier for each root.
  • d7c5790 Internal changes
  • a677b00 Sort root names before deduplicating them with numeric suffixes in order guar...
  • ba49e28 Generate all test components in a common directory separate from the test cla...
  • 9a068fc Migrate annotation classes to androidx
  • 32694a9 Pull AliasOfPropagatedDataMetadata into its own source file.
  • 0336b1a Pull DefineComponentClassesMetadata into its own source file.
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [dagger](https://github.com/google/dagger) from 2.28.3 to 2.34.1.
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](google/dagger@dagger-2.28.3...dagger-2.34.1)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 14, 2021
@rafalgawlik rafalgawlik merged commit bc401bc into master Apr 17, 2021
@dependabot dependabot bot deleted the dependabot/gradle/com.google.dagger-dagger-2.34.1 branch April 17, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant