Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: hyperlink to documentation #126

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Conversation

yecril23pl
Copy link
Contributor

No description provided.

@Kludex
Copy link
Owner

Kludex commented Feb 29, 2024

@yecril23pl Do you mind changing this to what we have in Starlette: https://github.com/encode/starlette (the "Documentation" between ---?

@yecril23pl
Copy link
Contributor Author

yecril23pl commented Feb 29, 2024

@yecril23pl Do you changing this to what we have in Starlette: https://github.com/encode/starlette (the "Documentation" between ---?

Of course I do. A URL is not something that a reader would like to see. It is like having a source reference in running text instead of a footnote.

@Kludex
Copy link
Owner

Kludex commented Feb 29, 2024

Sorry, I had a typo on my message.

@Kludex
Copy link
Owner

Kludex commented Mar 8, 2024

Feel free to open a PR analogous to what we have in Starlette. I'll close this for now.

@Kludex Kludex closed this Mar 8, 2024
@Kludex Kludex reopened this Mar 9, 2024
@Kludex Kludex merged commit 810ac1a into Kludex:master Mar 9, 2024
11 checks passed
@Kludex
Copy link
Owner

Kludex commented Mar 9, 2024

I've merged this because I didn't know how to reach the documentation 👀

Thanks 🙏

@yecril23pl
Copy link
Contributor Author

Wow. Just wow. Please be aware that this is not some random Python package, it is the official replacement for bundled cgi that has been deprecated. You are a Python VIP now, please act accordingly 😉

@yecril23pl yecril23pl deleted the patch-3 branch March 9, 2024 20:22
@Kludex
Copy link
Owner

Kludex commented Mar 9, 2024

Wow. Just wow. Please be aware that this is not some random Python package, it is the official replacement for bundled cgi that has been deprecated. You are a Python VIP now, please act accordingly 😉

Excuse me?

@yecril23pl
Copy link
Contributor Author

I understood this exchange as you refusing to acknowledge my argument against your review. While this is a common occurrence in private projects, projects that have gained crucial external importance such as this one cause earthquakes in the community if under authoritarian management (e.g. XFree86).

Repository owner locked and limited conversation to collaborators Mar 9, 2024
@Kludex
Copy link
Owner

Kludex commented Mar 9, 2024

Locking this to avoid further heat discussion that does not benefit anyone.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants