Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use trust_x_header and test it (fix #195) #196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use trust_x_header and test it (fix #195) #196

wants to merge 1 commit into from
+23 −1

Conversation

jhnstrk
Copy link
Contributor

@jhnstrk jhnstrk commented Dec 8, 2024

Use the boolean.

Note that this changes the default behavior but makes it consistent with what the function documentation was declaring.

If we want to maintain behaviour, we may want to expose this in option in parse_form.

@Kludex
Copy link
Owner

Kludex commented Dec 16, 2024 •
edited
Loading

Should we actually remove the parameter? 🤔

Do you think this makes sense @jhnstrk ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhnstrk @Kludex