feat: Fixing php stan

KminekMatej · Dec 7, 2024 · 19a4c82 · 19a4c82
1 parent 76bfaf2
commit 19a4c82
Show file tree

Hide file tree

Showing 11 changed files with 27 additions and 25 deletions.
diff --git a/app/module/autotest/app/attendance/AttendanceStatusTest.php b/app/module/autotest/app/attendance/AttendanceStatusTest.php
@@ -178,7 +178,7 @@ private function getStatusSetId(): int
 
     public function createRecord(): array
     {
-        //use creator from recorManager - can create status or statusSet
+        throw new \Nette\NotImplementedException();
     }
 
     public function mockRecord(): void

diff --git a/app/module/autotest/app/attendance/AttendanceTest.php b/app/module/autotest/app/attendance/AttendanceTest.php
@@ -155,7 +155,7 @@ public function testUnknownEvent(): void
 
     public function createRecord(): array
     {
-        //attendance are never created solely, always just posted to some event
+        throw new \Nette\NotImplementedException();
     }
 
     public function mockRecord(): array

diff --git a/app/module/autotest/app/authentication/IsTest.php b/app/module/autotest/app/authentication/IsTest.php
@@ -35,7 +35,7 @@ protected function mockChanges(): array
 
     public function createRecord(): array
     {
-        //not used in this test
+        throw new \Nette\NotImplementedException();
     }
 
     protected function getBasePath(): string

diff --git a/app/module/autotest/app/debt/DebtTest.php b/app/module/autotest/app/debt/DebtTest.php
@@ -32,7 +32,7 @@ public function testGet(): void
     public function testCRUDSingular(): void
     {
         $this->authorizeAdmin();
-        $recordId = $this->createRecord();
+        $recordId = $this->createRecord()["id"];
 
         $this->request($this->getBasePath() . "/" . $recordId)->expect(200, "array");
 
@@ -127,7 +127,7 @@ public function testBlankCaption(): void
         $data["caption"] = "";
         $this->request($this->getBasePath(), "POST", $data)->expect(400);
 
-        $recordId = $this->createRecord();
+        $recordId = $this->createRecord()["id"];
         $this->request($this->getBasePath() . "/" . $recordId, "PUT", ["caption" => ""])->expect(400);
     }
 
@@ -146,7 +146,7 @@ public function testDebtNegative(): void
         $data["amount"] = -13;
         $this->request($this->getBasePath(), "POST", $data)->expect(400);
 
-        $recordId = $this->createRecord();
+        $recordId = $this->createRecord()["id"];
         $this->request($this->getBasePath() . "/" . $recordId, "PUT", ["amount" => "-14"])->expect(400);
     }
 
@@ -173,7 +173,7 @@ public function testTeamOwesMe(): void
     public function testCRUDPlural(): void
     {
         $this->authorizeAdmin();
-        $recordId = $this->createRecord();
+        $recordId = $this->createRecord()["id"];
 
         $this->request($this->getBasePath() . "s/" . $recordId)->expect(200, "array");
 

diff --git a/app/module/autotest/app/event/EventTest.php b/app/module/autotest/app/event/EventTest.php
@@ -39,7 +39,7 @@ public function testCreateMultiple(): void
 
     public function testCRUDSingular(): void
     {
-        $recordId = $this->createRecord();
+        $recordId = $this->createRecord()["id"];
 
         $this->request($this->getBasePath() . "/" . $recordId)->expect(200, "array");
         $this->request($this->getBasePath() . "/" . $recordId . "/history")->expect(200, "array");

diff --git a/app/module/autotest/app/permission/PermissionTest.php b/app/module/autotest/app/permission/PermissionTest.php
@@ -36,7 +36,7 @@ public function testGetPlural(): void
 
     public function testCRUDSingular(): void
     {
-        $recordId = $this->createRecord();
+        $recordId = $this->createRecord()["id"];
 
         $this->request($this->getBasePath() . "/" . $recordId)->expect(200, "array");
 

diff --git a/app/module/autotest/app/poll/PollTest.php b/app/module/autotest/app/poll/PollTest.php
@@ -38,7 +38,7 @@ public function testCRUDSingular(): void
     {
         $this->authorizeAdmin();
 
-        $recordId = $this->createRecord();
+        $recordId = $this->createRecord()["id"];
 
         $this->request($this->getBasePath() . "/" . $recordId)->expect(200, "array");
 
@@ -72,7 +72,7 @@ public function testCRUDSingular(): void
     public function testCrudForbidden(): void
     {
         $this->authorizeAdmin();
-        $pollId = $this->createRecord();
+        $pollId = $this->createRecord()["id"];
         $this->createOptionsFor($pollId, 1);
         $optionsData = $this->request($this->getBasePath() . "/$pollId/options")->expect(200, "array")->getData();//poll doesnt exist
         $option = $optionsData[0];

diff --git a/app/module/autotest/app/user/UserTest.php b/app/module/autotest/app/user/UserTest.php
@@ -105,7 +105,7 @@ public function testStatus(): void
 
     public function testCRUD(): void
     {
-        $recordId = $this->createRecord();
+        $recordId = $this->createRecord()["id"];
 
         $this->request($this->getBasePath() . "/" . $recordId)->expect(200, "array");
 
@@ -266,7 +266,7 @@ public function testUpdateFailures(): void
         $adminData = $this->request($this->getBasePath() . "/1", "PUT", ["roles" => ["USR"]])->expect(200)->getData();
         Assert::contains("SUPER", $adminData["roles"]);
 
-        $userId = $this->createRecord();
+        $userId = $this->createRecord()["id"];
 
         $this->authorizeUser();
         $this->request($this->getBasePath() . "/$userId", "PUT", $this->mockChanges())->expect(403);
@@ -312,7 +312,7 @@ public function testAvatar(): void
         )->expect(400);
 
         $this->authorizeAdmin();
-        $userId = $this->createRecord();
+        $userId = $this->createRecord()["id"];
 
         $this->authorizeUser();
         $this->request(

diff --git a/app/module/autotest/entity/ApiTest.php b/app/module/autotest/entity/ApiTest.php
@@ -24,6 +24,15 @@ public function deleteRecord($recordId): void
         $this->recordManager->deleteRecord($this->getBasePath(), $recordId);
     }
 
+    protected function change(int $recordId, ?array $changes = null)
+    {
+        $changes = $changes ?: $this->mockChanges();
+
+        $changedData = $this->request($this->getBasePath() . "/" . $recordId, "PUT", $changes)->expect(200, "array")->getData();
+
+        $this->assertObjectEquality($changes, $changedData);
+    }
+
     //*************** COMMON TESTS, SAME FOR ALL MODULES
 
     public function testUnauthorized()

diff --git a/app/module/autotest/entity/RequestCase.php b/app/module/autotest/entity/RequestCase.php
@@ -137,15 +137,6 @@ protected function tearDown(): void
         $this->logs = [];
     }
 
-    protected function change(int $recordId, ?array $changes = null)
-    {
-        $changes = $changes ?: $this->mockChanges();
-
-        $changedData = $this->request($this->getBasePath() . "/" . $recordId, "PUT", $changes)->expect(200, "array")->getData();
-
-        $this->assertObjectEquality($changes, $changedData);
-    }
-
     /** @return SimpleResponse */
     public function request($url, $method = "GET", $data = [], $responseClass = null)
     {

diff --git a/app/module/autotest/entity/UITest.php b/app/module/autotest/entity/UITest.php
@@ -2,13 +2,14 @@
 
 namespace Tymy\Module\Autotest;
 
+use Nette\Application\IPresenter;
+use Nette\Application\UI\Presenter;
 use Tester\DomQuery;
 use Tymy\Module\Autotest\Entity\Assert;
-use Tymy\Module\Core\Presenter\Front\BasePresenter;
 
 abstract class UITest extends RequestCase
 {
-    protected BasePresenter $presenter;
+    protected IPresenter $presenter;
     protected string $presenterName;
 
     protected abstract function getPresenter(): string;
@@ -17,6 +18,7 @@ protected function setUp()
     {
         $this->presenterName = "{$this->getModule()}:{$this->getPresenter()}";
         $this->presenter = $this->presenterFactory->createPresenter($this->presenterName);
+        assert($this->presenter instanceof Presenter);
         $this->presenter->autoCanonicalize = false;
 
         parent::setUp();