fix(timecop gem): add support for Timecop 0.9.9 so that we could track proper tests' execution time when Process.clock_gettime is mocked
#262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k proper tests' execution time when Process.clock_gettime is mocked
Pacyfik
reviewed
Jun 19, 2024
lib/knapsack_pro/utils.rb
Outdated
| @@ -5,5 +5,13 @@ class Utils | |||
| def self.unsymbolize(obj) | |||
| JSON.parse(obj.to_json) | |||
| end | |||
|
|
|||
| def self.now | |||
There was a problem hiding this comment.
Just a personal opinion more than anything else - I'm not convinced Utils.now makes it clear that it returns the current time, maybe time_now? But feel free to ignore.
Pacyfik
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
link to the internal story
Related
Changes introduced by Timecop 0.9.9:
Process.clock_gettime is mocked.
Process.clock_gettimesupport travisjeffery/timecop#419Timecop 0.9.10 makes
Process.clock_gettimeoptionally mocked. The default isTimecop.mock_process_clock = false.Our old PRs related to time tracking and mocking time:
Description
Add support for Timecop 0.9.9 so that we could track proper tests' execution time when
Process.clock_gettimeis mocked.Changes
Process.clock_gettimemocked by the Timecop gem.Checklist reminder
UNRELEASEDsection of theCHANGELOG.md, including the needed bump (ie, patch, minor, major)lib/knapsack_pro/pure/queue/rspec_pure.rbcontains pure functions that are unit tested.lib/knapsack_pro/extensions/rspec_extension.rbencapsulates calls to RSpec internals and is integration and e2e tested.lib/knapsack_pro/runners/queue/rspec_runner.rbinvokes the pure code and the extension to produce side effects, which are integration and e2e tested.