-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Support for Quectel-specific NMEA Sentences (PQTM) in pynmea2 #169
Open
adedolapoadegboye
wants to merge
22
commits into
Knio:master
Choose a base branch
from
adedolapoadegboye:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated nmea.py to support parsing of concantenated PQTM messages updated nmea.py to support parsing of concantenated PQTM messages updated nmea.py to support parsing of concantenated PQTM messages
Code cleanup
Squashed multiple minor commits
Knio
reviewed
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't commit these files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description: Add Support for Quectel-specific NMEA Sentences in
pynmea2
Description
This PR introduces support for Quectel-specific NMEA sentences by adding new proprietary sentence classes under the
QTM
namespace. These classes enable parsing and handling of device-specific messages, such as GNSS status, configuration settings, geofencing, and more. This extends the library's capabilities for devices like Quectel's LC29H GNSS module.Changes Introduced
New Classes:
QTM
: Base class for Quectel proprietary sentences.QTMVERNO
: GNSS module version information.QTMSAVEPAR
: Save receiver parameters.QTMRESTOREPAR
: Restore receiver parameters.QTMEPE
: Outputs estimated positioning error.QTMCFGGEOFENCE
: Configure geofences.QTMGEOFENCESTATUS
: Geofence status.QTMCFGSVIN
: Survey-in mode configuration.QTMSVINSTATUS
: Survey-in status.QTMCFGRCVRMODE
: Receiver mode configuration.QTMDOP
: DOP values for GNSS accuracy.QTMPL
: GNSS protection levels.QTMCFGSBAS
: SBAS configuration.QTMCFGCNST
: GNSS constellation configuration.QTMCFGFIXRATE
: Configure GNSS fix rate.QTMVEL
: Velocity information.QTMCFGODO
: Configure the odometer feature.QTMODO
: Odometer status.Tests Added:
tests/test_qtm.py
.How it Works
QTM
base class dynamically assigns the appropriate subclass based on the first data element (manufacturer + data[0]
).build_date
,epe_north
,geofence state
, and others.__repr__
implementations for better debugging and logging outputs.Checklist
pytest
.