Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MTA sentence #170

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

a1rwulf
Copy link
Contributor

@a1rwulf a1rwulf commented Nov 11, 2024

We do work for the Yachting industry and deal with a lot of NMEA devices.
As part of our internal goal to centralize parsing, we decided to move all our parsing to pynmea2 and contribute back the sentences we come across in the field, starting with MTA.
I see that there were plans to phase this one out, but we still see it's being used by devices in the wild.

@hecko
Copy link

hecko commented Nov 11, 2024

Out of curiosity which device is this specifically using this sentence? Thanks!

@a1rwulf
Copy link
Contributor Author

a1rwulf commented Nov 12, 2024

@hecko I tried to figure this out, but I'm not exactly sure.
I believe it's a Moxa device, but can't give you a specific product as I don't have access to that information at the moment: https://www.moxa.com/en/solutions/marine

Edit:
It might very well be that the moxa units just multiplex the nmea inputs, so I really can't say which specific device we are talking about.

@a1rwulf
Copy link
Contributor Author

a1rwulf commented Nov 21, 2024

Is there any procedure one is supposed to follow in order to get PR's moving?

@coveralls
Copy link

Coverage Status

coverage: 97.977% (+0.005%) from 97.972%
when pulling 27b22c5 on yachtcloud:support-mta-sentence-upstream
into f298742 on Knio:master.

@Knio Knio merged commit d9eb144 into Knio:master Nov 22, 2024
8 checks passed
@a1rwulf
Copy link
Contributor Author

a1rwulf commented Nov 22, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants