Sort the internal list of voters by priority

[FlashBlack]

And piece of code in knp-menubundle
see: KnpLabs/KnpMenuBundle#268

[stof]

must keep compatibility with PHP 5.3

[stof]

Does KnpMenu really need a concept of priority ? I think running voters in the order in which they are added is enough here. the concept of priority should be used by the code configuring the matcher if needed (it may not be needed depending of how the configuration is done).
KnpMenuBundle could then use the priority to sort tagged services (to give control over the order in which voters are added). Symfony does that in many places (the EventDispatcher is one of the only place where the priority needs to be known by the code rather than the configuration layer btw)

[stof]

so I'm -1 on this change in the library.

[akovalyov]

@FlashBlack could you add a little bit of details why do you need this change?

[Nek-]

@akovalyov notice that the implementation is wrong, and need a test.

Btw I'm 👎 too as voter don't need to be prioritized: if a voter say "no", then it's no (a voter can return null). No matter the order. The only point I see here is to authorize bad application design (things that the voter should not do in the voter).

[stof]

If you need a strict order for voters, just register them in the right order. I don't want to add the concept of priority in the library.