-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to php 7.4 #365
upgrade to php 7.4 #365
Conversation
this also needs to remove the CI job running on PHP 7.3 (the lowest_deps job must not be removed, but updated to PHP 7.4 instead) |
15f72d1
to
59ef668
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove "dev" suffix from sf 5.4 and 6.0 in the build? Also, the "dev deps" should be on PHP 8.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's OK for me if we manage to solve the last failing test
@stephanvierkant any news on this? |
Thanks for your work @stephanvierkant The failing tests are because of the deprecation messages with --prefer-lowest argument. I did bump "psr/container": "^2.0", as we now have php 7.4 (but this is optional) I suggest to https://github.com/Chris53897/KnpMenu/blob/php74/composer.json Testrun: |
Dropping support for v1 is a bad idea. There is no reason for that in term of maintenance, and it increases the risk of dependency conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #357