Update PHPUnit (9 --> 10) #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garak
requested changes
Aug 2, 2024
composer.json
Outdated
| @@ -29,7 +29,7 @@ | |||
| }, | |||
| "require-dev": { | |||
| "phpstan/phpstan": "^1.11", | |||
| "phpunit/phpunit": "^9.6", | |||
| "phpunit/phpunit": "^10.5.29", | |||
There was a problem hiding this comment.
There is no need for the patch version. ^10.5 will be enough
garak
requested changes
Aug 2, 2024
.php-cs-fixer.php
Outdated
| @@ -17,6 +17,7 @@ | |||
| 'native_function_invocation' => ['include' => ['@all']], | |||
| 'final_class' => true, | |||
| 'php_unit_mock_short_will_return' => true, | |||
| 'nullable_type_declaration_for_default_null_value' => true, | |||
There was a problem hiding this comment.
This rule is already part of the Symfony group, so it's currently useless.
By the way, we should update the PHP80Migration group -> PHP81Migration
There was a problem hiding this comment.
Done. Thank you for the hints!
garak
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.