-
-
Notifications
You must be signed in to change notification settings - Fork 597
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bug #1135 Handle case of GitHub returning 204 No Content in some scen…
…arios (tomcorbett) This PR was squashed before being merged into the 3.14-dev branch. Discussion ---------- ResultPager breaks because no array is returned (it's an empty string) - issue ResultPager::get() can return string #1091 Commits ------- 8a3f154 Handle case of GitHub returning 204 No Content in some scenarios which breaks ResultPager because no array is returned (it's an empty string) - issue ResultPager::get() can return string #1091 4fff555 fix style issue raised by continuous-integration/styleci/pr eaa7993 Added unit test for case of GitHub API returning 204 empty content in ResultPager #1091 08c3d7a Updated based on feedback from continuous-integration/styleci/pr a3d2fb8 Another change requested by continuous-integration/styleci/pr (but not for my changed code)
- Loading branch information
1 parent
a162dd3
commit 61b478a
Showing
2 changed files
with
67 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters