Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feature #1053 Include optional params parameter for Commits compare m…
…ethod (mountiny) This PR was merged into the 3.4.x-dev branch. Discussion ---------- The Github compare API limits the response to only [250 commits](https://docs.github.com/en/rest/reference/commits#compare-two-commits). I have been testing this library and I have not been able to paginate the compare call without using the params array and adding the `per_page` key. Without it, I always got only 250 commits in the diff. When the `$params` is included, I have managed to get paginate all the commits from the Github API. Unfortunately, I cannot easily use the `all` call with the `since` parameter because I only have the base and head available. I think this change would be valuable in general, it should not break any existing behaviour and it will enable pagination for compare calls. Thank you very much for the review and considering this change, it would help a lot to our team. Commits ------- ed63fb6 Include optional params parameter for Commits compare
- Loading branch information