Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create blob only 'content' is required #1042

Closed
gemal opened this issue Dec 20, 2021 · 1 comment · Fixed by #1071
Closed

create blob only 'content' is required #1042

gemal opened this issue Dec 20, 2021 · 1 comment · Fixed by #1071
Labels
bug

Comments

@gemal
Copy link
Contributor

gemal commented Dec 20, 2021

https://github.com/KnpLabs/php-github-api/blob/master/lib/Github/Api/GitData/Blobs.php#L62

requires both content and encoding

but according to the documentation:
https://docs.github.com/en/rest/reference/git#create-a-blob

only content is required
@acrobat acrobat added the bug label Jun 12, 2022
@acrobat
Copy link
Collaborator

acrobat commented Jun 12, 2022

@gemal You are right! Can you send a PR to remove the encoding key from the check? Thanks!

gemal added a commit to gemal/php-github-api that referenced this issue Jun 13, 2022
@gemal
dont require encoding
89c71de 
fixes KnpLabs#1042
@gemal gemal mentioned this issue Jun 13, 2022
Merged
acrobat pushed a commit that referenced this issue Jun 17, 2022
@gemal
bug #1071 dont require encoding (gemal)
83b8a32 
This PR was squashed before being merged into the 3.4.x-dev branch.

Discussion
----------

fixes #1042

Commits
-------

89c71de dont require encoding
35c97c2 Update BlobsTest.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dont require encoding gemal/php-github-api
2 participants
@gemal @acrobat