Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typehint on \Github\Api\Repo->dispatch is wrong #1065

Closed
cweagans opened this issue May 18, 2022 · 0 comments · Fixed by #1066
Closed

Typehint on \Github\Api\Repo->dispatch is wrong #1065

cweagans opened this issue May 18, 2022 · 0 comments · Fixed by #1066

Comments

@cweagans
Copy link
Contributor

Github wants an object. We're passing an array. I added $clientPayload = (object) $clientPayload; as the first line of this method to verify. Typehinting object $clientPayload is probably better, but I'm not sure we can really change it without a BC break? Then again, if anyone was attempting to use this, they would have flagged this issue already.

PR incoming.
@cweagans cweagans mentioned this issue May 18, 2022
Merged
acrobat pushed a commit that referenced this issue Aug 1, 2022
@cweagans
feature #1066 Fix typehint for repository dispatch method (cweagans)
e15ee94 
This PR was squashed before being merged into the 3.4.x-dev branch.

Discussion
----------

Closes #1065

Commits
-------

714798c Fix typehint for repository dispatch method
5005773 styleci fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typehint for repository dispatch method cweagans/php-github-api
1 participant
@cweagans