Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typehint for repository dispatch method #1066

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Fix typehint for repository dispatch method #1066

merged 2 commits into from
Aug 1, 2022

Conversation

cweagans
Copy link
Contributor

Closes #1065

acrobat
acrobat reviewed Aug 1, 2022
View reviewed changes
Copy link
Collaborator

@acrobat acrobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cweagans Changes look ok to me, can you just apply the styleci suggested changes? Thanks!

@cweagans
Copy link
Contributor Author

cweagans commented Aug 1, 2022

@acrobat done.

@acrobat acrobat merged commit e15ee94 into KnpLabs:master Aug 1, 2022
@acrobat
Copy link
Collaborator

acrobat commented Aug 1, 2022

Thanks @cweagans! And congrats on your first contribution! 🎉

@cweagans cweagans deleted the 1065-repo-dispatch-typehint branch August 15, 2022 16:43
@cweagans cweagans mentioned this pull request Aug 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acrobat acrobat acrobat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typehint on \Github\Api\Repo->dispatch is wrong
2 participants
@cweagans @acrobat