Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow php-http/cache-plugin version 2 #1127

Closed
tacman opened this issue Nov 16, 2023 · 6 comments · Fixed by #1134
Closed

Allow php-http/cache-plugin version 2 #1127

tacman opened this issue Nov 16, 2023 · 6 comments · Fixed by #1134

Comments

@tacman
Copy link

tacman commented Nov 16, 2023

There's a deprecation warning triggered by this library because it's using 1.x of the php-http/cache-plugin

I think if you simply allowed either ^1.7 || ^2.0 it could use the later version that does not call the deprecated interface.

This might be related to #1119.

Specifically, it's this PR: php-http/cache-plugin@3562529
@acrobat
Copy link
Collaborator

acrobat commented Nov 19, 2023

@tacman can you provide the deprecation message you get? Thanks!

@tacman
Copy link
Author

tacman commented Nov 20, 2023

I'm not getting it anymore, perhaps they back ported the fix.

@tacman tacman closed this as completed Nov 20, 2023
@aszenz
Copy link

aszenz commented Nov 27, 2023

@tacman I'm still seeing this deprecation, looking at composer.json of v1:

https://github.com/php-http/cache-plugin/blob/1.x/composer.json#L17, it still requires the deprecated interface

@tacman
Copy link
Author

tacman commented Nov 27, 2023

Yep. I'll reopen.

@tacman tacman reopened this Nov 27, 2023
@aszenz
Copy link

aszenz commented Dec 9, 2023

Version 2 of php-http/cache-plugin is unreleased, only the branch is created

@antennaio antennaio mentioned this issue Feb 8, 2024
Closed
@ls-philippe-gamache
Copy link

2.0.0 release on 2024-02-19 17:02 UTC

@GrahamCampbell GrahamCampbell mentioned this issue Mar 17, 2024
Merged
acrobat added a commit that referenced this issue Mar 19, 2024
@acrobat
feature #1134 Allow php-http/cache-plugin v2 (GrahamCampbell)
5d66b9c 
This PR was merged into the 3.13-dev branch.

Discussion
----------

Closes #1127. Blocks GrahamCampbell/Laravel-GitHub#157.

Commits
-------

680eea2 Allow php-http/cache-plugin v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow php-http/cache-plugin v2
4 participants
@tacman @acrobat @aszenz @ls-philippe-gamache