Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General chores #1125

Merged
merged 2 commits into from
Oct 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/backwards-compatibility.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,13 @@ jobs:
with:
fetch-depth: 0

- name: Roave BC Check
uses: docker://nyholm/roave-bc-check-ga
- name: Install PHP
uses: shivammathur/setup-php@v2
with:
args: --from=${{ github.event.pull_request.base.sha }}
php-version: '8.2'

- name: Install roave/backward-compatibility-check
run: composer require --dev roave/backward-compatibility-check

- name: Run roave/backward-compatibility-check
run: vendor/bin/roave-backward-compatibility-check --from=${{ github.event.pull_request.base.sha }} --format=github-actions
1 change: 1 addition & 0 deletions lib/Github/Api/CurrentUser/Watchers.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* @link https://developer.github.com/v3/activity/watching/
*
* @author Joseph Bielawski <stloyd@gmail.com>
*
* @revised Felipe Valtl de Mello <eu@felipe.im>
*/
class Watchers extends AbstractApi
Expand Down
1 change: 0 additions & 1 deletion lib/Github/HttpClient/Plugin/GithubExceptionThrower.php
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ public function handleRequest(RequestInterface $request, callable $next, callabl
$errors[] = $error['message'];
}
break;

}
}

Expand Down
1 change: 1 addition & 0 deletions test/Github/Tests/Api/Enterprise/StatsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ public function shouldShowStats()

/**
* @test
*
* @dataProvider getTypes
*/
public function shouldShowStatsByType($type)
Expand Down
1 change: 1 addition & 0 deletions test/Github/Tests/Api/Repository/AssetsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public function shouldGetSingleReleaseAsset()

/**
* @test
*
* @requires PHP 5.3.4
*/
public function shouldCreateReleaseAsset()
Expand Down
1 change: 1 addition & 0 deletions test/Github/Tests/Api/Repository/ContentsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ public function getFailureStubsForExistsTest()
* @param \PHPUnit_Framework_MockObject_Stub|\PHPUnit\Framework\MockObject\Stub\Exception
*
* @test
*
* @dataProvider getFailureStubsForExistsTest
*/
public function shouldReturnFalseWhenFileIsNotFound($failureStub)
Expand Down
3 changes: 3 additions & 0 deletions test/Github/Tests/ClientTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public function shouldPassHttpClientInterfaceToConstructor()

/**
* @test
*
* @dataProvider getAuthenticationFullData
*/
public function shouldAuthenticateUsingAllGivenParameters($login, $password, $method)
Expand Down Expand Up @@ -115,6 +116,7 @@ public function shouldThrowExceptionWhenAuthenticatingWithoutMethodSet()

/**
* @test
*
* @dataProvider getApiClassesProvider
*/
public function shouldGetApiInstance($apiName, $class)
Expand All @@ -126,6 +128,7 @@ public function shouldGetApiInstance($apiName, $class)

/**
* @test
*
* @dataProvider getApiClassesProvider
*/
public function shouldGetMagicApiInstance($apiName, $class)
Expand Down
3 changes: 3 additions & 0 deletions test/Github/Tests/Integration/IssueCommentTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ public function shouldRetrieveCommentsForIssue()

/**
* @test
*
* @depends shouldRetrieveCommentsForIssue
*/
public function shouldRetrieveSingleComment($commentId)
Expand Down Expand Up @@ -72,6 +73,7 @@ public function shouldCreateCommentForIssue()

/**
* @test
*
* @depends shouldCreateCommentForIssue
*/
public function shouldUpdateCommentByCommentId($commentId)
Expand All @@ -94,6 +96,7 @@ public function shouldUpdateCommentByCommentId($commentId)

/**
* @test
*
* @depends shouldUpdateCommentByCommentId
*/
public function shouldRemoveCommentByCommentId($commentId)
Expand Down
3 changes: 3 additions & 0 deletions test/Github/Tests/Integration/RepoCommentTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ public function shouldCreateCommentForCommit()

/**
* @test
*
* @depends shouldCreateCommentForCommit
*/
public function shouldShowCommentByCommentId($commentId)
Expand All @@ -91,6 +92,7 @@ public function shouldShowCommentByCommentId($commentId)

/**
* @test
*
* @depends shouldShowCommentByCommentId
*/
public function shouldUpdateCommentByCommentId($commentId)
Expand All @@ -113,6 +115,7 @@ public function shouldUpdateCommentByCommentId($commentId)

/**
* @test
*
* @depends shouldUpdateCommentByCommentId
*/
public function shouldRemoveCommentByCommentId($commentId)
Expand Down