Prepare for 2.7 release #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
force-pushed
the
nyholm-patch-1
branch
from
457f064 to
6cd7aab
Compare
acrobat
reviewed
Dec 12, 2017
CHANGELOG.md
Outdated
| - Phpunit 6 compatibility | ||
| The following classes and endpoints were deprecated by Github and are also deprecated in the client: | ||
|
|
||
| - `Github\Api\Repo` |
There was a problem hiding this comment.
The whole class is deprecated..
acrobat
reviewed
Dec 12, 2017
CHANGELOG.md
Outdated
| The following classes and endpoints were deprecated by Github and are also deprecated in the client: | ||
|
|
||
| - `Github\Api\Repo` | ||
| - `Github\Api\User` |
acrobat
reviewed
Dec 12, 2017
CHANGELOG.md
Outdated
|
|
||
| - `Github\Api\Repo` | ||
| - `Github\Api\User` | ||
| - `Github\Api\Issue::all()` |
|
Oh, you are correct. Sorry |
acrobat
reviewed
Dec 12, 2017
CHANGELOG.md
Outdated
|
|
||
| - `Github\Api\Repo::find()` | ||
| - `Github\Api\User::find()` | ||
| - `Github\Api\Issue::all()` |
There was a problem hiding this comment.
This also has to be the find() method instead of all()
|
There. Im done with this PR now |
|
Thank you for the reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.