Default settings #58
Closed
Default settings #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default token will be used across all windows where a specific token has not been set. This will ease debugging when keeping multiple windows open, and reinstalling the app gives the debug device a new token. No need to copy-paste it into several windows anymore.
Prepares for allowing identity selection from settings to set a global identity for all windows
Now called APNSIdentity, this wrapper makes it easier to juggle multiple identities without caring about manual memory management.
Makes it a little prettier and adds a clarifying text.
|
I don't think I have seen this behaviour in other document apps. The token should be saved by the document, and maybe we should find a way to store a reference to the identity as well? |
|
The token is saved by the document just like before. If one wants to, the default settings can be ignored and the app can be used exactly as before. This is more of a fallback if no token has been entered in a document. I agree that this isn't common in document-based apps. But I also think it's uncommon for document-based apps to have something that is so commonly shared between documents as the token is in Knuff. Now that I think about it, "Fallback Settings" is probably a better terminology for this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some functionality that made life easier for us at Football Addicts when testing notifications.
Our workflow is usually to have a lot of Knuff windows open with different payloads to test multiple things. It was quite annoying to have to set the token and identity for each window individually.
This has been fixed by adding a settings window where one can choose a default token and identity. The defaults will be used in any window where a token and identity has not been set. Setting the token and identity normally will override the default settings for a window.