Ta/update experimental 20240129 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the check for invalid multipliers in `ComboObjectiveFunction`. Move private methods used for validation of arguments to private functions since they didn't need any other attribute of the class. Add tests for the new checks for invalid multipliers.
Co-authored-by: Joseph Capriotti <josephrcapriotti@gmail.com>
Fix issue with lengthscales in coterminal angle calculations
Simplify check for invalid multipliers
…e-experimental-20240129 * commit '6edc293dacbd1b873a7fcea15ae49cbdb3364836': Apply joe's suggestion to other components. Update SimPEG/regularization/regularization_mesh.py Simplify check for invalid multipliers
jedman
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update to latest simpeg/simpeg-main