fix: Fix duplicate action being published under rare circumstances K…

…oenkk/zigbee2mqtt#20024
Koenkk · Dec 15, 2023 · 172a386 · 172a386
1 parent 05485ec
commit 172a386
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/lib/utils.ts b/src/lib/utils.ts
@@ -65,13 +65,14 @@ export function mapNumberRange(value: number, fromLow: number, fromHigh: number,
     return precisionRound(mappedValue, precision);
 }
 
-const transactionStore: {[s: string]: number} = {};
+const transactionStore: {[s: string]: number[]} = {};
 export function hasAlreadyProcessedMessage(msg: Fz.Message, model: Definition, ID: number=null, key: string=null) {
     if (model.meta && model.meta.publishDuplicateTransaction) return false;
     const currentID = ID !== null ? ID : msg.meta.zclTransactionSequenceNumber;
     key = key || msg.device.ieeeAddr;
-    if (transactionStore[key] === currentID) return true;
-    transactionStore[key] = currentID;
+    if (transactionStore[key]?.includes(currentID)) return true;
+    // Keep last 5, as they might come in different order: https://github.com/Koenkk/zigbee2mqtt/issues/20024
+    transactionStore[key] = [currentID, ...transactionStore[key]].slice(0, 5);
     return false;
 }