Fixed Legrand/Bticino LedInDark feature #6032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianMangold
changed the title
Koenkk
reviewed
Aug 2, 2023
src/converters/fromZigbee.js
Outdated
| @@ -3930,6 +3930,13 @@ const converters = { | |||
| } | |||
| }, | |||
| }, | |||
| legrand_ledInDark: { | |||
There was a problem hiding this comment.
Please rename to legrand_led_in_dark
There was a problem hiding this comment.
Sure, done! (Sorry, first contribution)
Koenkk
reviewed
Aug 2, 2023
src/devices/legrand.js
Outdated
| // Some require coverInverted: | ||
| // - https://github.com/Koenkk/zigbee2mqtt/issues/15101#issuecomment-1356787490 | ||
| // - https://github.com/Koenkk/zigbee2mqtt/issues/16090 | ||
| fingerprint: [ |
There was a problem hiding this comment.
Why was this removed? It will break 067776 for some users.
There was a problem hiding this comment.
That's correct, and it was not my intention to break anything.
Until recently, this was required as there was no other alternative. Now that OTA is available, those devices work perfectly with the classic (non inverted) 067776.
I am preparing another PR with more extensive changes to the 067776, (add support for Venetian / BSO mode) and wanted to avoid duplication.
The change has been reverted for now nevertheless, hope that is OK.
FabianMangold
force-pushed
the
master
branch
2 times, most recently
from
c2b68df
to
8dc26df
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: