Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: IKEA VINDSTYRKA uses different DataType for measuredValue #7450

Merged
merged 3 commits into from
Apr 28, 2024

Conversation

sjorge
Copy link
Contributor

@sjorge sjorge commented Apr 27, 2024

Now that we have Koenkk/zigbee-herdsman#1019, we can properly fix the IKEA VINDSTYRKA.

  • modernExtend to easily inject them by abstracting the onEvent stuff
  • VINDSTYRKA should use correct DataType
  • make SONOFF device also use new modernExtend

This is the debug log of joining a VINDSTYRKA and reconfiguring the reporting for pm25Measurement.measuredValue via the frontend.

vindstyrka_join_and_configreport.log

@sjorge sjorge changed the title Vindstyrka add cluster @sjorge fix: IKEA VINDSTYRKA uses different DataType for measuredValue Apr 27, 2024
@sjorge sjorge changed the title @sjorge fix: IKEA VINDSTYRKA uses different DataType for measuredValue fix: IKEA VINDSTYRKA uses different DataType for measuredValue Apr 27, 2024
src/lib/modernExtend.ts Outdated Show resolved Hide resolved
@Koenkk
Copy link
Owner

Koenkk commented Apr 28, 2024

Looks really nice with the modernExtend refactor!

@sjorge
Copy link
Contributor Author

sjorge commented Apr 28, 2024

Renamed and rebased.

@sjorge
Copy link
Contributor Author

sjorge commented Apr 28, 2024

I forgot to mention, this should fix all the vindstyrka issues either people trying to reconfigure reporting 😀

@Koenkk Koenkk merged commit 6d328d1 into Koenkk:master Apr 28, 2024
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Apr 28, 2024

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants