Use common motor_state values for Bosch & Lumi devices
#7470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `stopped` instead of `idle` so integrations can expect a common, minimum set of `motor_state` values.
burmistrzak
changed the title
motor_state values for Bosch BCMT-SLZmotor_state values for Bosch & Lumi devices
burmistrzak
changed the title
motor_state values for Bosch & Lumi devicesmotor_state values for Bosch & Lumi devices
|
Thanks! |
|
I believe this may have caused some issues with the Aqara ZNJLBL01LM roller. The issue is mentioned above. |
@GoodnessJSON Huh, that's strange... This PR explicitly introduced these common states to avoid such situations. 🤔 Edit: Yeah, my bad. Totally forgot about |
|
No worries at all, thanks for the quick action on this one :) Good fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a shared set of
motor_statevalues so integrations can standardize around them.openingclosingstoppedblockedAffected devices: