Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ubisys.ts #7972

Merged
merged 5 commits into from
Sep 11, 2024
Merged

Update ubisys.ts #7972

merged 5 commits into from
Sep 11, 2024

Conversation

chris-1243
Copy link
Contributor

It is a following of #7669. I did not want to modify legacy.fz.ubisys_c4. It seems something is not working and I have the feeling it would be better to use what is already created.
This way, it is quite easy to roll back. In the future, it might be a good idea to clear the code for this device. I do not have the knowledge for this unfortunately.

It is a following of Koenkk#7669. I did not want to modify legacy.fz.ubisys_c4. It seems something is not working and I have the feeling it would be better to use what is already created.
@chris-1243
Copy link
Contributor Author

Anyone could check where the error is ? For the moment, I have mounted the whole ubysis.ts file in my docker container and it is working

Code style issues found in the above file

is the error I get during the check.

@Koenkk Koenkk merged commit a699873 into Koenkk:master Sep 11, 2024
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Sep 11, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants