Workaround IKEA bulbs freezing during a brightness & color transition #8637
+99
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobrippling
force-pushed
the
feat/ikea-workaround
branch
from
a854d5b to
da0194d
Compare
bobrippling
force-pushed
the
feat/ikea-workaround
branch
from
da0194d to
a5f1cfe
Compare
bobrippling
commented
Jan 18, 2025
| @@ -3,6 +3,7 @@ import {Zcl} from 'zigbee-herdsman'; | |||
| import * as libColor from '../lib/color'; | |||
| import * as constants from '../lib/constants'; | |||
| import * as exposes from '../lib/exposes'; | |||
| import {unfreezeMechanisms, UnfreezeSupport} from '../lib/ikea'; | |||
There was a problem hiding this comment.
I feel like vendor-specific imports shouldn't be here and the logic from ../lib/ikea should be inlined into the ikea_bulb_unfreeze converter below
bobrippling
commented
Jan 18, 2025
| @@ -210,6 +211,7 @@ const definitions: DefinitionWithExtend[] = [ | |||
| vendor: 'IKEA', | |||
| description: 'TRADFRI bulb B22, white spectrum, globe, opal, 1055 lm', | |||
| extend: [addCustomClusterManuSpecificIkeaUnknown(), ikeaLight({colorTemp: true}), m.identify()], | |||
| toZigbee: [tz.ikea_bulb_unfreeze], | |||
There was a problem hiding this comment.
This could specify different unfreeze mechanisms in the future (as in the original code), but I only have this one bulb type to test with, so I'm just changing this for now
bobrippling
commented
Jan 18, 2025
| const frozenUtil = globalStore.getValue(this.entity, 'frozenUntil'); | ||
| if (frozenUtil != null) { | ||
| if (Date.now() <= frozenUtil) { | ||
| console.log('Light is frozen, will attempt to unfreeze'); |
There was a problem hiding this comment.
This (and below) will be changed to a proper logger call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, see discussion in Koenkk/zigbee2mqtt#18574