Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve endpoint->configureReporting to handle manufacturer specific clusters/attributes #717

Closed
sjorge opened this issue Jun 7, 2023 · 4 comments · Fixed by #748
Closed

Improve endpoint->configureReporting to handle manufacturer specific clusters/attributes #717

sjorge opened this issue Jun 7, 2023 · 4 comments · Fixed by #748
Labels
dont-stale stale

Comments

@sjorge
Copy link
Contributor

sjorge commented Jun 7, 2023

#712 (comment)

We should include some extra info so we correctly identify which manufacturer cluster and or attribute was configured.
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2023

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale label Jul 8, 2023
@sjorge
Copy link
Contributor Author

sjorge commented Jul 8, 2023

@Koenkk is the TS refactor of zhc done?

@Koenkk
Copy link
Owner

Koenkk commented Jul 8, 2023

No not yet, I became a father a few weeks ago so I have less time to spend (so don't expect it to be done soon)

@sjorge
Copy link
Contributor Author

sjorge commented Jul 8, 2023

No not yet, I became a father a few weeks ago so I have less time to spend (so don't expect it to be done soon)

First of all, Congratulations! Can we add the do not stale label to this issue, so it doesn't get closed.

@tomasbedrich tomasbedrich mentioned this issue Aug 2, 2023
Merged
Koenkk added a commit that referenced this issue Aug 20, 2023
@Koenkk
fix: Fix incorrect configured reporting cluster returned when cluster…
8aa3fae 
… is manufacturer specific #717
@Koenkk Koenkk mentioned this issue Aug 20, 2023
Merged
Koenkk added a commit that referenced this issue Aug 24, 2023
@Koenkk
fix: Fix incorrect configured reporting cluster returned when cluster…
bff9d4d 
… is manufacturer specific (#748)

* fix: Fix incorrect configured reporting cluster returned when cluster is manufacturer specific #717

* updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dont-stale stale
Projects
None yet
Milestone
No milestone
2 participants
@sjorge @Koenkk