Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zigate: Fix ZDO BIND/UNBIND payload mismatch. #1198

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

Nerivec
Copy link
Collaborator

@Nerivec Nerivec commented Sep 23, 2024

Fixes #1187 (comment)
Tested against old payloads, should now match exactly.
Note: It might even be possible to remove the entire alteration for BIND/UNBIND, as long as zigate doesn't try to read the unused endpoint at the end (it shouldn't). Would require testing with actual adapter though.

CC: @devbis

@Koenkk Koenkk merged commit b007282 into Koenkk:master Sep 23, 2024
1 check passed
@Koenkk
Copy link
Owner

Koenkk commented Sep 23, 2024

Thanks!

@Nerivec Nerivec deleted the zigate-bind-payload-fix branch September 23, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants