Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New device support]: Support for CTM Lyng mKomfy Tak #22974

Closed
mixedbreed opened this issue Jun 8, 2024 · 4 comments
Closed

[New device support]: Support for CTM Lyng mKomfy Tak #22974

mixedbreed opened this issue Jun 8, 2024 · 4 comments
Labels
new device support New device support request

Comments

@mixedbreed
Copy link

Link

https://www.zigbee2mqtt.io/devices/mKomfy_Sensor.html

Database entry

{"id":33,"type":"EndDevice","ieeeAddr":"0x6c5cb1fffe1a3338","nwkAddr":11476,"manufId":4919,"manufName":"CTM Lyng","powerSource":"Battery","modelId":"mKomfy Tak","epList":[1],"endpoints":{"1":{"profId":260,"epId":1,"devId":770,"inClusterList":[0,1,3,1026,65261,65481],"outClusterList":[3,25,4096],"clusters":{"genBasic":{"attributes":{"modelId":"mKomfy Tak","manufacturerName":"CTM Lyng","powerSource":3,"zclVersion":8,"appVersion":10,"stackVersion":106,"swBuildId":"1.0"}},"genPowerCfg":{"attributes":{"batteryPercentageRemaining":198}},"msTemperatureMeasurement":{"attributes":{"measuredValue":2200}}},"binds":[{"cluster":1,"type":"endpoint","deviceIeeeAddress":"0x00124b00257ccc68","endpointID":1},{"cluster":1026,"type":"endpoint","deviceIeeeAddress":"0x00124b00257ccc68","endpointID":1}],"configuredReportings":[{"cluster":1,"attrId":33,"minRepIntval":3600,"maxRepIntval":65000,"repChange":10,"manufacturerCode":null},{"cluster":1026,"attrId":0,"minRepIntval":10,"maxRepIntval":3600,"repChange":100,"manufacturerCode":null}],"meta":{}}},"appVersion":10,"stackVersion":106,"swBuildId":"1.0","zclVersion":8,"interviewCompleted":true,"meta":{"configured":1324213189},"lastSeen":1717830579280}

Comments

Hello, would like to add device CTM Lyng mKomfy Tak to Z2M.
CTM Lyng mKomfy Tak is the roof sensor integrated to the all ready supported stove guard.
See link: https://www.zigbee2mqtt.io/devices/mKomfy_Sensor.html

Please see the attached external definition.

BR
Mixedbreed

External definition

const {battery, identify, temperature} = require('zigbee-herdsman-converters/lib/modernExtend');

const definition = {
    zigbeeModel: ['mKomfy Tak'],
    model: 'mKomfy Tak',
    vendor: 'CTM Lyng',
    description: 'Automatically generated definition',
    extend: [battery(), identify(), temperature()],
    meta: {},
};

module.exports = definition;
@mixedbreed mixedbreed added the new device support New device support request label Jun 8, 2024
Koenkk added a commit to Koenkk/zigbee-herdsman-converters that referenced this issue Jun 8, 2024
@Koenkk
Copy link
Owner

Koenkk commented Jun 8, 2024

Added!

Could you also submit a picture for the docs? This can be done by clicking here.

Make sure that:

  • The filename is MODEL.png (update model accordingly)
  • The size is 512x512
  • The background is transparent (use e.g. Adobe remove background)

@mixedbreed
Copy link
Author

Hello and thanks again.
The picture is already uploaded as part of the documentation for CTM Lyng Stove Guard where you can see both the stove guard and the roof sensor.
Please see link of image.

https://www.zigbee2mqtt.io/images/devices/mKomfy_Sensor.png

Have a nice weekend!

@overskeid
Copy link

A better way to do this would be to simply add 'mKomfy Tak' to the 'mKomfy_Sensor' converter.
Like this:
zigbeeModel: ['mKomfy', 'mKomfy Tak'],
model: 'mKomfy_Sensor',
vendor: 'CTM Lyng',
description: 'mKomfy, stove guard',

Then you will get more functionality as well.

Stian, CTM Lyng

@mixedbreed
Copy link
Author

mixedbreed commented Aug 3, 2024

A better way to do this would be to simply add 'mKomfy Tak' to the 'mKomfy_Sensor' converter. Like this: zigbeeModel: ['mKomfy', 'mKomfy Tak'], model: 'mKomfy_Sensor', vendor: 'CTM Lyng', description: 'mKomfy, stove guard',

Then you will get more functionality as well.

Stian, CTM Lyng

Thanks for the suggestion Stian, but wouldn't it be better to add it to correct supported device instead of a "hack" with converters?

Tried btw to add it temporary via converters. But does not add any functionality?
Have I written anything wrong or must it be reincluded?

const {battery, battery_low, temperature, alarm_status, active, linkquality} = require('zigbee-herds$

const definition = {
zigbeeModel: ['mKomfy', 'mKomfy Tak'],
model: 'mKomfy_Sensor',
vendor: 'CTM Lyng',
description: 'mKomfy, stove guard',
extend: [battery(), battery_low(), temperature(), alarm_status(), active(), linkquality()],
};

module.exports = definition;

BR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new device support New device support request
Projects
None yet
Development

No branches or pull requests

3 participants