Always return an object when loading a YAML file #20289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty or containing the `null` value. Fixes Koenkk#20283
|
Thanks! Could you add a test for this? I think you can reuse this one |
…is test breaks without the proposed.
|
Sure, I've added a test for testing an empty, second device file. Without the fix, the test fails. |
|
Thanks! |
This was referenced Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If loading an empty file or a file that only contains comments, yaml.load() returns null, which is the cause for #20283. This PR should make loading of YAML file more robust, as I don't think anybody relies on the special behavior of getting a null for an empty file.