Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release dev #22502

Closed
wants to merge 2 commits into from
Closed

chore: release dev #22502

wants to merge 2 commits into from

Conversation

Koenkk
Copy link
Owner

@Koenkk Koenkk commented May 6, 2024

🤖 I have created a release beep boop

1.37.1

1.37.1 (2024-05-09)

Bug Fixes

1.37.1

1.37.1 (2024-05-09)

Bug Fixes


This PR was generated with Release Please. See documentation.

@Koenkk
Copy link
Owner Author

Koenkk commented May 6, 2024

@jlpedrosa looks good now, many thanks!

@jlpedrosa
Copy link
Contributor

@jlpedrosa looks good now, many thanks!

At your service, feel free to ping me if this is causing issues. I will test this as soon as the release is created.

@Koenkk
Copy link
Owner Author

Koenkk commented May 6, 2024

@jlpedrosa yes, will ping you with the next release, since we are planning a hotfix release it should come soon.

@Koenkk Koenkk force-pushed the release-please--branches--dev branch from bfd85c5 to e24aa16 Compare May 6, 2024 20:00
@jlpedrosa
Copy link
Contributor

I am not sure if it was the force push the reason why the CI is stuck, in actions all seems correct....

@Koenkk Koenkk force-pushed the release-please--branches--dev branch from 02a8871 to 44b73b5 Compare May 7, 2024 19:25
@jlpedrosa
Copy link
Contributor

Since the CI generates another commit, not sure if the force push is confusion to the CI system? maybe instead of force pushing, maybe an empty commit?

git commit --allow-empty -m "Empty-Commit"

@jlpedrosa
Copy link
Contributor

@Koenkk I see one step is failing from the previous steps of the CI.
image
Let me have a look

@jlpedrosa
Copy link
Contributor

Humm, the output is empty, there's not a single log line.
It seems

node scripts/generateChangelog.js $MASTER_Z2M_VERSION $MASTER_ZHC_VERSION $MASTER_ZH_VERSION $MASTER_FRONTEND_VERSION >> ../changelog.md

is having issues, I don't have a clue of Javascript, but I don't think it's using any file that has been modified by the helm chart.
I have tried to reproduce it locally with the two branches checked out, but it works on my pc. Not sure what I can do to help.

@Koenkk Koenkk force-pushed the release-please--branches--dev branch 2 times, most recently from cf37b01 to 4b52355 Compare May 8, 2024 20:33
@Koenkk
Copy link
Owner Author

Koenkk commented May 8, 2024

@jlpedrosa the branch name changed due to jlpedrosa@04e0e3f, fixed it in 834626d

@Koenkk Koenkk force-pushed the release-please--branches--dev branch from 4b52355 to de3ca04 Compare May 8, 2024 20:50
@jlpedrosa
Copy link
Contributor

Yeah, that makes sense, but I don't see the CI trigger for the next commit... it's strange:
image

I am not sure if it's the force push...

@jlpedrosa
Copy link
Contributor

I see the CI is configured for push, not sure why the other commit is not triggering it. I don't know if it's the loop protection from GH.

on: [pull_request, push]

@Koenkk
Copy link
Owner Author

Koenkk commented May 8, 2024

GH doesn't run pipelines for commits done via Github actions, adding the token should fix it (aecdfe6)

@jlpedrosa
Copy link
Contributor

GH doesn't run pipelines for commits done via Github actions, adding the token should fix it (aecdfe6)

Yeah, that decision was apparently intentional to prevent loops. that is what I meant.

When you use the repository's GITHUB_TOKEN to perform tasks, events triggered by the GITHUB_TOKEN, with the exception of workflow_dispatch and repository_dispatch, will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs.

https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow

@Koenkk Koenkk force-pushed the release-please--branches--dev branch from 2bc9fb0 to 883f5ba Compare May 8, 2024 21:16
@Koenkk
Copy link
Owner Author

Koenkk commented May 8, 2024

Works now! 🥳

@jlpedrosa
Copy link
Contributor

🥳 !!!
image

Thanks man!

@Koenkk Koenkk force-pushed the release-please--branches--dev branch from 74334dd to 146d8a7 Compare May 9, 2024 06:18
@Koenkk Koenkk force-pushed the release-please--branches--dev branch from 55790ab to 1e3f911 Compare May 9, 2024 19:42
@Koenkk Koenkk closed this May 9, 2024
@Koenkk Koenkk deleted the release-please--branches--dev branch May 9, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants