fix: Remove extraneous whitespace in template for binary attributes #24520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I assume Home Assistant strips the whitespace at some point before comparing it to payload_on/payload_off, but I haven't quite found where yet. I have confirmed Python preserves the whitespace when simply evaluating the Jinja. For openHAB, it does not strip the whitespace, causing errors because it doesn't match the payload_on or payload_off values. At some point I'd like to bring openHAB inline with Home Assistant, but I need to do so carefully without breaking something unexpectedly (especially with non- Home Assistant MQTT integrations). In the meantime, this should fix the issue in openHAB, without causing issues for Home Assistant or any other software that follows Home Assistant's MQTT discovery process.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume Home Assistant strips the whitespace at some point before comparing it to payload_on/payload_off, but I haven't quite found where yet. I have confirmed Python preserves the whitespace when simply evaluating the Jinja.
For openHAB, it does not strip the whitespace, causing errors because it doesn't match the payload_on or payload_off values. At some point I'd like to bring openHAB inline with Home Assistant, but I need to do so carefully without breaking something unexpectedly (especially with non- Home Assistant MQTT integrations). In the meantime, this should fix the issue in openHAB, without causing issues for Home Assistant or any other software that follows Home Assistant's MQTT discovery process.