Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update homeassistant.ts #24538

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Update homeassistant.ts #24538

merged 1 commit into from
Oct 29, 2024

Conversation

Bacchus777
Copy link
Contributor

Added power_phase_b and power_phase_c

Added power_phase_b and power_phase_c
@Koenkk Koenkk merged commit e0a0f86 into Koenkk:dev Oct 29, 2024
11 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Oct 29, 2024

Thanks!

@magicus
Copy link
Contributor

magicus commented Nov 1, 2024

@Bacchus777 What is the reasoning for putting these in the diagnostics category? Was it just to mimicpower?

I have recently installed a Zigbee EV charger, and it is very strange to me that the power consumption (which is one of the key data I want to get out of it) is considered a "diagnostic". I thought this was a mistake and were planning to open a PR which would remove that, but I was wondering what caused someone to put it in that category to begin with.

@Bacchus777
Copy link
Contributor Author

@Bacchus777 What is the reasoning for putting these in the diagnostics category? Was it just to mimicpower?

I have recently installed a Zigbee EV charger, and it is very strange to me that the power consumption (which is one of the key data I want to get out of it) is considered a "diagnostic". I thought this was a mistake and were planning to open a PR which would remove that, but I was wondering what caused someone to put it in that category to begin with.

I made it just like a power was. But i thing all these objects (power, voltage, current and energy) must not be a diagnostic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants