For devices with 'queryState' set, we read state after write. #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some devices don't send an update of their state when we change it, and with this method we can force them to by requesting it.
|
Thanks for the PR, first I would like to continue the discussion in #999. If you want we can also have a chat, as I think this is far more efficient (I'm on telegram as koenkk) |
|
Superseded by #1004. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the discussion in #939 some devices (like my AduroSmart lights) don't send device updates. To properly know the state of the device after we set it, we can issue a get command. This change will always do that for devices that have
queryStateset to true.I decided to implement it like this, in a more generic way. This works fine for me. If you approve this PR, I'll submit one to actually include
querystatefor the device. The other option is to just make a few converters for this device and setreadAfterWriteTimefor those - I've tried that and that also works fine. Let me know if you prefer that and I'll make a PR accordingly,