Implement --check option #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlsmedstad
force-pushed
the
implement-check-option
branch
from
426cc6c to
16144a3
Compare
|
You should rebase all commits into one. |
Chose to return 2 when formatting is needed to make this distinct from actual errors which return 1. Additional changes: * Add basic .editorconfig * Add long-form arg --in-place * Implement function file_is_usable Separates and encapsulates this logic to make the main function a bit more terse and readable. * Replace istream_iterator with istreambuf_iterator Tested with both and it seems like the resulting string is the same using this. Same case for the removal of the std::noskipws.
carlsmedstad
force-pushed
the
implement-check-option
branch
from
16144a3 to
1c75c92
Compare
|
Sure thing, done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
The functionality is more or less exactly the same as described in the issue. I also included some minor refactoring commits and added a basic
.editorconfig. Happy to receive feedback on these changes if they are out of place or considered non-improvements.Resolves #142.