Add type constraints to Environment definiton #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the breaking change introduced by odbc-safe 0.5.1
Closed
|
Yanked odbc-safe 0.5.1 and rereleased as 0.6.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the breaking change introduced by odbc-safe 0.5.1 (pacman82/odbc-safe@366d5c2).
I understand that you may prefer to pin the dependency to 0.5.0 and have me take this issue to the other crate, since they shouldn't have pushed a backwards-incompatible change in a patch update, but as of 2 weeks ago the crate's been deprecated, so I figured it couldn't hurt to just open this PR. Relevant issue in other crate at pacman82/odbc-safe#16, wherein the maintainer recommends the approach of pinning to 0.5.0 in a patch update.