Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add folder support for metadata_path config #360

Closed
zpz5HAU-tgc3fgw2xwr opened this issue Aug 13, 2021 · 3 comments · Fixed by #362
Closed

Feature Request: Add folder support for metadata_path config #360

zpz5HAU-tgc3fgw2xwr opened this issue Aug 13, 2021 · 3 comments · Fixed by #362
Assignees
Labels
enhancement New feature or request status:added-to-develop Feature Request or Bug Fix is in Develop

Comments

@zpz5HAU-tgc3fgw2xwr
Copy link

Discussion here: #357

@zpz5HAU-tgc3fgw2xwr zpz5HAU-tgc3fgw2xwr added enhancement New feature or request status:not-yet-viewed I haven't reviewed the Feature or Bug yet labels Aug 13, 2021
@meisnate12
Copy link
Member

its already added to develop lol

@meisnate12 meisnate12 added status:added-to-develop Feature Request or Bug Fix is in Develop and removed status:not-yet-viewed I haven't reviewed the Feature or Bug yet labels Aug 14, 2021
@zpz5HAU-tgc3fgw2xwr
Copy link
Author

Having some issues getting this working. I set the folder path the same way it was setup for my asset_directory: path

I wasn't sure if it would automatically dig through subdirectories or not (it would be cool if it could). The file I'm trying to access is at config/shows/quickfixes/______.yml

config.yml

libraries:
  Shows:
    metadata_path:
      - folder: config/shows

meta.log

[2021-08-14 01:39:52,575] [plex_meta_manager.py:111]  [INFO]     |           Version: 1.11.3-beta5                                                                    |
[2021-08-14 01:39:52,575] [util.py:184]               [INFO]     |====================================================================================================|
[2021-08-14 01:39:54,804] [config.py:339]             [INFO]     | Connecting to Shows Library...                                                                     |
[2021-08-14 01:39:54,833] [meta.py:19]                [INFO]     | Loading Metadata Folder: config/shows                                                              |
[2021-08-14 01:39:54,834] [util.py:137]               [DEBUG]    | Traceback (most recent call last):                                                                 |
                                                                 |   File "/modules/meta.py", line 47, in __init__
                                                                 |     content = open(path, encoding="utf-8")
                                                                 | IsADirectoryError: [Errno 21] Is a directory: 'config/shows'
                                                                 | 
[2021-08-14 01:39:54,834] [plex.py:265]               [ERROR]    | YAML Error: [Errno 21] Is a directory: 'config/shows'
[2021-08-14 01:39:54,834] [plex.py:268]               [INFO]     | 
[2021-08-14 01:39:54,835] [util.py:137]               [DEBUG]    | Traceback (most recent call last):
                                                                 |   File "/modules/config.py", line 410, in __init__
                                                                 |     library = Plex(self, params)
                                                                 |   File "/modules/plex.py", line 269, in __init__
                                                                 |     raise Failed("Metadata File Error: No valid metadata files found")
                                                                 | modules.util.Failed: Metadata File Error: No valid metadata files found
                                                                 | 
[2021-08-14 01:39:54,835] [util.py:134]               [ERROR]    | Metadata File Error: No valid metadata files found
[2021-08-14 01:39:54,835] [config.py:416]             [INFO]     | Shows Library Connection Failed
[2021-08-14 01:39:54,835] [util.py:184]               [INFO]     |====================================================================================================|
[2021-08-14 01:39:54,836] [util.py:137]               [DEBUG]    | Traceback (most recent call last):                                                                 |
                                                                 |   File "//plex_meta_manager.py", line 122, in start
                                                                 |     config = Config(default_dir, config_path=config_path, is_test=is_test,
                                                                 |   File "/modules/config.py", line 495, in __init__
                                                                 |     raise Failed("Plex Error: No Plex libraries were connected to")
                                                                 | modules.util.Failed: Plex Error: No Plex libraries were connected to
                                                                 | 
[2021-08-14 01:39:54,836] [plex_meta_manager.py:128]  [CRITICAL] | Plex Error: No Plex libraries were connected to
[2021-08-14 01:39:54,836] [plex_meta_manager.py:129]  [INFO]     | 
[2021-08-14 01:39:54,836] [util.py:184]               [INFO]     |====================================================================================================|
[2021-08-14 01:39:54,836] [util.py:188]               [INFO]     |                                            Finished Run                                            |
[2021-08-14 01:39:54,836] [util.py:188]               [INFO]     |                                         Run Time: 0:00:02                                          |
[2021-08-14 01:39:54,836] [util.py:192]               [INFO]     |====================================================================================================|

And here's my second attempt:
config.yml

libraries:
  Shows:
    metadata_path:
      - folder: config/shows/quickfixes

meta.log

[2021-08-14 01:45:35,297] [plex_meta_manager.py:111]  [INFO]     |           Version: 1.11.3-beta5                                                                    |
[2021-08-14 01:45:35,297] [util.py:184]               [INFO]     |====================================================================================================|
[2021-08-14 01:45:37,971] [config.py:339]             [INFO]     | Connecting to Shows Library...                                                                     |
[2021-08-14 01:45:37,994] [meta.py:19]                [INFO]     | Loading Metadata Folder: config/shows/quickfixes                                                   |
[2021-08-14 01:45:37,995] [util.py:137]               [DEBUG]    | Traceback (most recent call last):                                                                 |
                                                                 |   File "/modules/meta.py", line 47, in __init__
                                                                 |     content = open(path, encoding="utf-8")
                                                                 | IsADirectoryError: [Errno 21] Is a directory: 'config/shows/quickfixes'
                                                                 | 
[2021-08-14 01:45:37,995] [plex.py:265]               [ERROR]    | YAML Error: [Errno 21] Is a directory: 'config/shows/quickfixes'
[2021-08-14 01:45:37,995] [plex.py:268]               [INFO]     | 
[2021-08-14 01:45:37,996] [util.py:137]               [DEBUG]    | Traceback (most recent call last):
                                                                 |   File "/modules/config.py", line 410, in __init__
                                                                 |     library = Plex(self, params)
                                                                 |   File "/modules/plex.py", line 269, in __init__
                                                                 |     raise Failed("Metadata File Error: No valid metadata files found")
                                                                 | modules.util.Failed: Metadata File Error: No valid metadata files found
                                                                 | 
[2021-08-14 01:45:37,996] [util.py:134]               [ERROR]    | Metadata File Error: No valid metadata files found
[2021-08-14 01:45:37,996] [config.py:416]             [INFO]     | Shows Library Connection Failed
[2021-08-14 01:45:37,996] [util.py:184]               [INFO]     |====================================================================================================|
[2021-08-14 01:45:37,996] [util.py:137]               [DEBUG]    | Traceback (most recent call last):                                                                 |
                                                                 |   File "//plex_meta_manager.py", line 122, in start
                                                                 |     config = Config(default_dir, config_path=config_path, is_test=is_test,
                                                                 |   File "/modules/config.py", line 495, in __init__
                                                                 |     raise Failed("Plex Error: No Plex libraries were connected to")
                                                                 | modules.util.Failed: Plex Error: No Plex libraries were connected to
                                                                 | 
[2021-08-14 01:45:37,996] [plex_meta_manager.py:128]  [CRITICAL] | Plex Error: No Plex libraries were connected to
[2021-08-14 01:45:37,997] [plex_meta_manager.py:129]  [INFO]     | 
[2021-08-14 01:45:37,997] [util.py:184]               [INFO]     |====================================================================================================|
[2021-08-14 01:45:37,997] [util.py:188]               [INFO]     |                                            Finished Run                                            |
[2021-08-14 01:45:37,997] [util.py:188]               [INFO]     |                                         Run Time: 0:00:02                                          |
[2021-08-14 01:45:37,997] [util.py:192]               [INFO]     |====================================================================================================|

I also tried changing - folder: to - directory: based on the error message. That just said this, which made me think that wasn't the issue.

| Metadata File Error: No valid metadata files found                                                 |

meisnate12 added a commit that referenced this issue Aug 14, 2021
@meisnate12
Copy link
Member

should have this fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request status:added-to-develop Feature Request or Bug Fix is in Develop
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants